Football match info lineups #14977
Football match info lineups #14977
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
marjisound
force-pushed
the
football-match-info
branch
from
0215533 to
ef07c91
Compare
marjisound
added
run_chromatic
marjisound
force-pushed
the
football-match-info
branch
from
ef07c91 to
74dd303
Compare
| corners: 10, | ||
| fouls: 4, | ||
| colours: '#ffffff', | ||
| colours: '#01009a', |
There was a problem hiding this comment.
I changed this temporarily until we fix the colour contrast
marjisound
force-pushed
the
football-match-info
branch
2 times, most recently
from
8f3df12 to
6e67ba0
Compare
| return ( | ||
| <ul css={isHome ? homeStyles : awayStyles}> | ||
| {team.players | ||
| .filter((player) => player.substitute === isSubstitute) |
There was a problem hiding this comment.
Why are we filtering the substitutes?
There was a problem hiding this comment.
There are 2 different sections one for lineups (Players who are not substitutes) and the other for substitutes. So because the PlayerList is used for both of them, here we're checking if the component is to be used for the lineups section or the substitute section (depending the value of isSubstitute)
marjisound
force-pushed
the
football-match-info
branch
from
6e67ba0 to
bc1aa7d
Compare
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @marjisound 9 minutes and 8 seconds ago) Please check your changes! |
What does this change?
This PR adds a new component
Lineups. In upcoming PRs this component will be placed within another componentMatchInfowhich holds other information about a match. The final aim is to use the MatchInfo component on match info and match report pages.NOTE
Currently the team colors are retrieved dynamically from the data. As you can see, sometimes the colours might not have a good contrast. There is going to be an upcoming PR with a solution to fix the colour contrast.
Why?
Migrating/re-desiging the football match pages for both apps/web
Screenshots
This PR fixes part of #14904